fix(libra):add new/old file path in libra diff output#1126
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two issues: updating type information in generated types for Libra and improving the file path output in the diff command.
- Change user_id type in generated type from a number with an int64 format annotation to a string.
- Refine the diff output in the Libra command to correctly distinguish between new, removed, and updated files.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| moon/packages/types/generated.ts | Change of user_id type from number to string, removing the int64 comment. |
| libra/src/command/diff.rs | Added logic to correctly display file paths for new, removed, and updated files. |
Comments suppressed due to low confidence (1)
moon/packages/types/generated.ts:3236
- Verify that changing the type of user_id from number to string is intentional, and update the corresponding documentation or comments to reflect this change if needed.
user_id: string
genedna
enabled auto-merge
June 16, 2025 13:35
genedna
approved these changes
Jun 16, 2025
Collaborator
Author
|
link #1106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.